Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fixed env issue in MacOS executable #372

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(api): fixed env issue in MacOS executable #372

merged 1 commit into from
Jan 15, 2024

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Jan 15, 2024 •
edited
Loading

Issue

Closes #371

Intent

  • Fix MacOS executable env loading issue.

Implementation

  • Added execPath check to setProcessVariables func in api/src/utils/setProcessVariables.ts to provide a path to the .env file located in the same folder with the MacOS executable.
  • Updated dotenv package.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@YuryShkoda YuryShkoda merged commit 6f2c535 into main Jan 15, 2024
3 checks passed
@YuryShkoda YuryShkoda deleted the issue-371 branch January 15, 2024 13:18
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.35.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabhas sabhas Awaiting requested review from sabhas

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executable @sasjs/server file should pick up environment variables from local .env file
2 participants
@YuryShkoda @Yury4GL